]> dgit.raspbian.org Git - gnome-shell.git/commit
dnd: Make startDrag() fail if there is a current grab
authorCarlos Garnacho <carlosg@gnome.org>
Tue, 12 Mar 2019 00:53:16 +0000 (01:53 +0100)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Wed, 13 Mar 2019 17:22:35 +0000 (17:22 +0000)
commit4a7e2ddff521e32b7206e5f346d2fc699400a345
treebe287a0bb5227b6a50897af5375ff5e574e20130
parentfb737ebde0b354ca63df67ef8d95e7dc92a1c74e
dnd: Make startDrag() fail if there is a current grab

This call just went through stomping over previous drag operations if any,
_maybeStartDrag() accounted for this, but other callers (well, WindowClone
in workspace.js) don't. This must bail out early even if a drag operation is
requested, luckily all callers account for it already.

This broke shell state by preserving connected captured-event handlers if
one tried to drag multiple windows simultaneously through multitouch. We
of course don't support that, now more elegantly.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/455
js/ui/dnd.js